Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI support for ReadOptions::iterate_lower_bound #4444

Closed
wants to merge 2 commits into from
Closed

JNI support for ReadOptions::iterate_lower_bound #4444

wants to merge 2 commits into from

Conversation

moozzyk
Copy link
Contributor

@moozzyk moozzyk commented Oct 2, 2018

Fixes: #4401

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@seancarroll
Copy link

Should we remove There is no lower bound on the iterator from the setIterateUpperBound and iterateUpperBound javadocs?

@moozzyk
Copy link
Contributor Author

moozzyk commented Oct 3, 2018

@seancarroll - not sure. The way I read this comment is that "There is no lower bound on the iterator." applies to the forward iterator discussed in the comment. In that sense this information is still correct. On the other hand, because it is a forward iterator, having a lower bound should not matter so maybe this sentence is not needed at all?

@seancarroll
Copy link

Ah yes that makes sense.

@sagar0 sagar0 self-assigned this Oct 3, 2018
Copy link
Contributor

@sagar0 sagar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution!

Copy link
Contributor

@sagar0 sagar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. lgtm!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants