Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printf formatting on MacOS #4533

Closed
wants to merge 2 commits into from

Conversation

graetzer
Copy link
Contributor

@graetzer graetzer commented Oct 17, 2018

On MacOS with clang the compilation of tools/db_bench_tool.cc always fails because the format used in a fprintf call has the wrong type. This PR should hopefully fix this issue

tools/db_bench_tool.cc:4233:61: error: format specifies type 'unsigned long long' but the argument has type 'size_t' (aka 'unsigned long')

@maysamyabandeh
Copy link
Contributor

Thanks @graetzer There might be more of such issues. Can you apply this patch to the PR so that i) we prevent such mistakes in future ii) we find and fix if there is any other issues in tools built under mac.

--- a/.travis.yml
+++ b/.travis.yml
@@ -90,7 +90,7 @@ script:
       OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=db_block_cache_test ROCKSDBTESTS_END=full_filter_block_test make -j4 check_some
       ;;
     2)
-      OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=full_filter_block_test ROCKSDBTESTS_END=write_batch_with_index_test make -j4 check_some
+      OPT=-DTRAVIS V=1 make -j4 tools && OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=full_filter_block_test ROCKSDBTESTS_END=write_batch_with_index_test make -j4 check_some
       ;;
     3)
       OPT=-DTRAVIS V=1 ROCKSDBTESTS_START=write_batch_with_index_test ROCKSDBTESTS_END=write_prepared_transaction_test make -j4 check_some

@maysamyabandeh
Copy link
Contributor

A kind reminder.

@graetzer
Copy link
Contributor Author

ok did that

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maysamyabandeh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants