WriteBufferManager JNI fixes #4579
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eBufferManager life as lifetime of Options Summary: Had bugs in PR: facebook#4492 which is fixed in this Test Plan: test cases Reviewers: bclay, sowmyalakshmip JIRA Issues: RTSG-3808 Differential Revision: https://phabricator.twitter.biz/D231875
…ing tests more robust
benclay
reviewed
Oct 23, 2018
java/rocksjni/options.cc
Outdated
| void Java_org_rocksdb_DBOptions_setWriteBufferManager(JNIEnv* /*env*/, jobject /*jobj*/, | ||
| jlong jdb_options_handle, | ||
| jlong jwrite_buffer_manager_handle) { | ||
| auto* write_buffer_manager = |
There was a problem hiding this comment.
Tabs are still a bit funny here
|
Problems in the master code are:
|
sagar0
reviewed
Oct 24, 2018
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public WriteBufferManager getWriteBufferManager() { |
There was a problem hiding this comment.
This should be just writeBufferManager() to conform to the naming pattern of other getters.
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public WriteBufferManager getWriteBufferManager() { |
There was a problem hiding this comment.
done! at other places too
sagar0
changed the title
There was a problem hiding this comment.
sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
sagar0
approved these changes
Oct 24, 2018
mikekap
pushed a commit
to ladderlife/frocksdb
that referenced
this pull request
Jun 27, 2019
Summary: 1. `WriteBufferManager` should have a reference alive in Java side through `Options`/`DBOptions` otherwise, if it's GC'ed at java side, native side can seg fault. 2. native method `setWriteBufferManager()` in `DBOptions.java` doesn't have it's jni method invocation in rocksdbjni which is added in this PR 3. `DBOptionsTest.java` is referencing object of `Options`. Instead it should be testing against `DBOptions`. Seems like a copy paste error. 4. Add a getter for WriteBufferManager. Pull Request resolved: facebook/rocksdb#4579 Differential Revision: D10561150 Pulled By: sagar0 fbshipit-source-id: 139a15c7f051a9f77b4200215b88267b48fbc487
mikekap
pushed a commit
to ladderlife/frocksdb
that referenced
this pull request
Jun 27, 2019
Summary: 1. `WriteBufferManager` should have a reference alive in Java side through `Options`/`DBOptions` otherwise, if it's GC'ed at java side, native side can seg fault. 2. native method `setWriteBufferManager()` in `DBOptions.java` doesn't have it's jni method invocation in rocksdbjni which is added in this PR 3. `DBOptionsTest.java` is referencing object of `Options`. Instead it should be testing against `DBOptions`. Seems like a copy paste error. 4. Add a getter for WriteBufferManager. Pull Request resolved: facebook/rocksdb#4579 Differential Revision: D10561150 Pulled By: sagar0 fbshipit-source-id: 139a15c7f051a9f77b4200215b88267b48fbc487
Myasuka
pushed a commit
to Myasuka/frocksdb
that referenced
this pull request
Oct 31, 2019
Summary: 1. `WriteBufferManager` should have a reference alive in Java side through `Options`/`DBOptions` otherwise, if it's GC'ed at java side, native side can seg fault. 2. native method `setWriteBufferManager()` in `DBOptions.java` doesn't have it's jni method invocation in rocksdbjni which is added in this PR 3. `DBOptionsTest.java` is referencing object of `Options`. Instead it should be testing against `DBOptions`. Seems like a copy paste error. 4. Add a getter for WriteBufferManager. Pull Request resolved: facebook/rocksdb#4579 Differential Revision: D10561150 Pulled By: sagar0 fbshipit-source-id: 139a15c7f051a9f77b4200215b88267b48fbc487
StephanEwen
pushed a commit
to ververica/frocksdb
that referenced
this pull request
Nov 21, 2019
Summary: 1. `WriteBufferManager` should have a reference alive in Java side through `Options`/`DBOptions` otherwise, if it's GC'ed at java side, native side can seg fault. 2. native method `setWriteBufferManager()` in `DBOptions.java` doesn't have it's jni method invocation in rocksdbjni which is added in this PR 3. `DBOptionsTest.java` is referencing object of `Options`. Instead it should be testing against `DBOptions`. Seems like a copy paste error. 4. Add a getter for WriteBufferManager. Pull Request resolved: facebook/rocksdb#4579 Differential Revision: D10561150 Pulled By: sagar0 fbshipit-source-id: 139a15c7f051a9f77b4200215b88267b48fbc487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteBufferManagershould have a reference alive in Java side throughOptions/DBOptionsotherwise, if it's GC'ed at java side, native side can seg fault.setWriteBufferManager()inDBOptions.javadoesn't have it's jni method invocation in rocksdbjni which is added in this PRDBOptionsTest.javais referencing object ofOptions. Instead it should be testing againstDBOptions. Seems like a copy paste error.