Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling option to trace_analyzer #4635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhichao-cao
Copy link
Contributor

If the trace is very large or user want to sample the trace first based on the sampling ratio, user can set the sample_ratio to partially analyze the trace. It is based on every X query of one type, analyze one query. X = (1.0/sample_ratio).

Test plan: tested through the trace analyzing and test

Copy link
Contributor

@sagar0 sagar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@sagar0 sagar0 changed the title Add the sampling option to trace_analyzer Add sampling option to trace_analyzer Nov 13, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours may need attention.

You currently have a CLA record in our system (either from being a fromer employee or from a previous collaboration) that may require an update. Please email cla@fb.com with your name, GitHub id, email address, screenshot of your attempt to sign the CLA at code.facebook.com/cla, and whether you are are a former employee, so we can update your status.

Note that if you feel this message is in error, occasionally the message appears transiently and the CLA bot will catch up and comment that your CLA is still in tact. So please give a few minutes before sending the email. Thank you.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants