New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Transaction::GetForUpdate with do_validate #4680
Closed
maysamyabandeh
wants to merge
21
commits into
facebook:master
from
maysamyabandeh:getforupdate-skipvalidate
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4590fed
extend GetForUpdate with skip_validate
maysamyabandeh b1e221c
the rest of the changes
maysamyabandeh 8f5e290
update history
maysamyabandeh 39cd1dd
updata java
maysamyabandeh 9c22a0b
return latest values if skip_validate
maysamyabandeh 9ba8b00
minor fix
maysamyabandeh bf046b2
extend writes with assume_exclusive_tracked
maysamyabandeh e7d4c49
make format
maysamyabandeh fcb4dc7
add unit test
maysamyabandeh 7fbdad7
fix java failures
maysamyabandeh 9898410
return error if skip_validate and snapshot are both set
maysamyabandeh 27d2656
skip_validate -> do_validate
maysamyabandeh 578afa5
update java docs
maysamyabandeh 3d71cef
untracked -> do_validate
maysamyabandeh 1ccc46a
assume_exclusive_tracked -> assume_tracked
maysamyabandeh fa56e6c
apply comments
maysamyabandeh cef4c72
remove UNLIKELY
maysamyabandeh b17c7b4
remove assert
maysamyabandeh 386fc22
rename the remaining assume_exclusive_tracked
maysamyabandeh 68894ee
remove another UNLIKELY
maysamyabandeh b3e2c3c
Update HISTORY
maysamyabandeh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant assume_tracked=true here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. will fix it.