Switch Travis to Xenial build #4789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is Travis failure related? |
adamretter
force-pushed
the
feature/travis/xenial
branch
from
c646a52
to
9017dde
Compare
|
@siying possibly a problem with CMake. I just rebased and pushed again, let's see what happens... |
adamretter
force-pushed
the
feature/travis/xenial
branch
9 times, most recently
from
1afacff
to
3d481a9
Compare
adamretter
force-pushed
the
feature/travis/xenial
branch
from
3d481a9
to
3bd5fc0
Compare
tamird
approved these changes
Jun 16, 2019
| @@ -1,5 +1,9 @@ | |||
| cmake_minimum_required(VERSION 3.4) | |||
|
|
|||
| if(${CMAKE_VERSION} VERSION_LESS "3.11.4") | |||
| message("Please consider switching to CMake 3.11.4 or newer") | |||
There was a problem hiding this comment.
You already error out in the relevant case below - is this warning helpful?
| set(JNI_OUTPUT_DIR ${PROJECT_SOURCE_DIR}/java/include) | ||
| file(MAKE_DIRECTORY ${JNI_OUTPUT_DIR}) | ||
|
|
||
| if(${Java_VERSION_MAJOR} VERSION_GREATER_EQUAL "10" AND ${CMAKE_VERSION} VERSION_LESS "3.11.4") |
There was a problem hiding this comment.
i believe any version 3.11 or higher is sufficient
|
Let me land it now to cut the round trip time. Follow up comments can be addressed with follow up PR. |
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request has been merged in d1ae67b. |
vagogte
pushed a commit
to vagogte/rocksdb
that referenced
this pull request
Jun 18, 2019
Summary: I think this should now also run on Travis's new virtualised infrastructure which affords more memory and CPU. We also need to think about migrating from travis-ci.org to travis-ci.com. Pull Request resolved: facebook#4789 Differential Revision: D15856272 fbshipit-source-id: 10b41d21924e8a362bc9646a63ccd1a5dfc437c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should now also run on Travis's new virtualised infrastructure which affords more memory and CPU.
We also need to think about migrating from travis-ci.org to travis-ci.com.