Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cast to avoid loss of precision error #4906

Closed
wants to merge 1 commit into from
Closed

add cast to avoid loss of precision error #4906

wants to merge 1 commit into from

Conversation

miasantreble
Copy link
Contributor

this PR address the following error:

tools/db_bench_tool.cc:4776:68: error: implicit conversion loses integer precision: 'int64_t' (aka 'long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
s = db_with_cfh->db->Put(write_options_, key, gen.Generate(value_size));

anand1976
anand1976 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sagar0
sagar0 approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@sagar0 sagar0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I just noticed this in my local build, sorry!

facebook-github-bot
facebook-github-bot reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miasantreble has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@miasantreble miasantreble deleted the fix-clang-error branch January 24, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@sagar0 sagar0 sagar0 approved these changes

@anand1976 anand1976 anand1976 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miasantreble @sagar0 @facebook-github-bot @anand1976