Make statistics's stats_level change thread-safe #5030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Right now, users can change statistics.stats_level while DB is running, but TSAN may report data race. We make stats_level_ to be atomic, and access them using accessors. Test Plan: Run existing tests.
riversand963
approved these changes
Feb 28, 2019
include/rocksdb/statistics.h
Outdated
| @@ -514,8 +514,16 @@ class Statistics { | |||
| virtual bool HistEnabledForType(uint32_t type) const { | |||
| return type < HISTOGRAM_ENUM_MAX; | |||
| } | |||
| void set_stats_level(StatsLevel sl) { | |||
| stats_level_.store(sl, std::memory_order_relaxed); | |||
| ; | |||
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
The java failure shows up occasionally in master too: https://travis-ci.org/facebook/rocksdb/builds/500087774 https://travis-ci.org/facebook/rocksdb/jobs/500079011 https://travis-ci.org/facebook/rocksdb/jobs/500066964 so I assume it's unrelated. |
vagogte
pushed a commit
to vagogte/rocksdb
that referenced
this pull request
Jun 18, 2019
Summary: Right now, users can change statistics.stats_level while DB is running, but TSAN may report data race. We make stats_level_ to be atomic, and access them using accessors. Pull Request resolved: facebook#5030 Differential Revision: D14267519 Pulled By: siying fbshipit-source-id: 37d7ebeff7a43a406230143422a16af899163f73
suizman
added a commit
to suizman/qed
that referenced
this pull request
Jul 11, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Related BBVA#114
suizman
added a commit
to suizman/qed
that referenced
this pull request
Sep 23, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Remove some functiones in our extended bindings which are no more required by this new version of Rocksdb Related BBVA#114
suizman
added a commit
to suizman/qed
that referenced
this pull request
Sep 25, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Remove some functiones in our extended bindings which are no more required by this new version of Rocksdb Related BBVA#114
suizman
added a commit
to suizman/qed
that referenced
this pull request
Sep 26, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Remove some functiones in our extended bindings which are no more required by this new version of Rocksdb Related BBVA#114
suizman
added a commit
to BBVA/qed
that referenced
this pull request
Sep 30, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Remove some functiones in our extended bindings which are no more required by this new version of Rocksdb Related #114 Former-commit-id: 71e024c
suizman
added a commit
to BBVA/qed
that referenced
this pull request
Sep 30, 2019
Minor changes in statistics -> facebook/rocksdb#5030 Remove some functiones in our extended bindings which are no more required by this new version of Rocksdb Related #114 Former-commit-id: bfe2771 [formerly 71e024c] Former-commit-id: 3248422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now, users can change statistics.stats_level while DB is running, but TSAN may report
data race. We make stats_level_ to be atomic, and access them using accessors.
Test Plan: Run existing tests.