Fix compilation errors for 32bits/LITE/ios build. #5220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siying
reviewed
Apr 19, 2019
table/block_based_table_builder.cc
Outdated
| @@ -1064,7 +1064,7 @@ void BlockBasedTableBuilder::EnterUnbuffered() { | |||
| if (!r->data_block_and_keys_buffers.empty()) { | |||
| while (compression_dict_samples.size() < kSampleBytes) { | |||
| size_t rand_idx = | |||
| generator.Uniform(r->data_block_and_keys_buffers.size()); | |||
| (size_t)generator.Uniform(r->data_block_and_keys_buffers.size()); | |||
There was a problem hiding this comment.
use C++ style casting static_cast<>. Same in other places.
We are following Google C++ Style and it is the suggestion there: https://google.github.io/styleguide/cppguide.html#Casting
There was a problem hiding this comment.
Ok, I have updated the coding style.
siying
reviewed
Apr 20, 2019
table/block_based_table_builder.cc
Outdated
| @@ -1064,7 +1064,7 @@ void BlockBasedTableBuilder::EnterUnbuffered() { | |||
| if (!r->data_block_and_keys_buffers.empty()) { | |||
| while (compression_dict_samples.size() < kSampleBytes) { | |||
| size_t rand_idx = | |||
| generator.Uniform(r->data_block_and_keys_buffers.size()); | |||
| static_cast<size_t>(generator.Uniform(r->data_block_and_keys_buffers.size())); | |||
There was a problem hiding this comment.
Can you wrap the line into 80-char?
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@siying is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vagogte
pushed a commit
to vagogte/rocksdb
that referenced
this pull request
Jun 18, 2019
Summary:
When I build RocksDB for 32bits/LITE/iOS environment, some errors like the following.
`
table/block_based_table_reader.cc:971:44: error: implicit conversion loses integer precision: 'uint64_t'
(aka 'unsigned long long') to 'size_t' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
size_t block_size = props_block_handle.size();
~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~^~~~~~
./util/file_reader_writer.h:177:8: error: private field 'env_' is not used [-Werror,-Wunused-private-field]
Env* env_;
^
`
Pull Request resolved: facebook#5220
Differential Revision: D15023481
Pulled By: siying
fbshipit-source-id: 1b5d121d3016f2b0a8a9a2cc1bd638479357f9f7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I build RocksDB for 32bits/LITE/iOS environment, some errors like the following.
`
table/block_based_table_reader.cc:971:44: error: implicit conversion loses integer precision: 'uint64_t'
(aka 'unsigned long long') to 'size_t' (aka 'unsigned long') [-Werror,-Wshorten-64-to-32]
size_t block_size = props_block_handle.size();
~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~^~~~~~
./util/file_reader_writer.h:177:8: error: private field 'env_' is not used [-Werror,-Wunused-private-field]
Env* env_;
^
`