-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PATENTS text from a few straggler files #5326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
// of patent rights can be found in the PATENTS file in the same directory. | ||
// This source code is licensed under both the GPLv2 (found in the | ||
// COPYING file in the root directory) and Apache 2.0 License | ||
// (found in the LICENSE.Apache file in the root directory). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not that file under a BSD from LevelDB originally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if this file came from LevelDB. Even if it did, we still have the BSD-related text on lines 6-8, similar to other LevelDB-imported files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these are mostly from relatively new files, and from open-source community. They probably tested with older versions in their branches, and forgot to update the files. This specific file was from a pull request of @yuslepukhin. All his other files followed the new header. So I believe it was mistake.
Thanks! |
The PPC related files were contributed by IBM, and I believe the reason the old license text is still in these files is because both RocksDB-license-change and IBM-ppc-crc-contribution happened around the same time (or at least were in review during an intersecting period). The ppc files could have originally been created by just copy-pasting the standard old template header from other files at that time. |
Summary: Remove PATENTS related wording from a few stragglers which still reference the old PATENTS file. Pull Request resolved: facebook#5326 Differential Revision: D15423297 Pulled By: sagar0 fbshipit-source-id: 4babcddfc120b7d2fed6eb3898287cf8012bf8ea
Remove PATENTS related wording from a few stragglers which still reference the old PATENTS file.