Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PATENTS text from a few straggler files #5326

Closed
wants to merge 1 commit into from

Conversation

sagar0
Copy link
Contributor

@sagar0 sagar0 commented May 20, 2019

Remove PATENTS related wording from a few stragglers which still reference the old PATENTS file.

@sagar0 sagar0 requested review from gfosco and siying May 20, 2019 21:22
@sagar0 sagar0 changed the title Remove PATENTS line from a few straggler files Remove PATENTS text from a few straggler files May 20, 2019
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sagar0 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

// of patent rights can be found in the PATENTS file in the same directory.
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not that file under a BSD from LevelDB originally?

Copy link
Contributor Author

@sagar0 sagar0 May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this file came from LevelDB. Even if it did, we still have the BSD-related text on lines 6-8, similar to other LevelDB-imported files.

Copy link
Contributor

@siying siying May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these are mostly from relatively new files, and from open-source community. They probably tested with older versions in their branches, and forgot to update the files. This specific file was from a pull request of @yuslepukhin. All his other files followed the new header. So I believe it was mistake.

@pombredanne
Copy link

Thanks!
I wonder if that was not kept back because of the LevelDB and/or International Business Machines extra copyrights?

@sagar0
Copy link
Contributor Author

sagar0 commented May 21, 2019

I wonder if that was not kept back because of the LevelDB and/or International Business Machines extra copyrights?

The PPC related files were contributed by IBM, and I believe the reason the old license text is still in these files is because both RocksDB-license-change and IBM-ppc-crc-contribution happened around the same time (or at least were in review during an intersecting period). The ppc files could have originally been created by just copy-pasting the standard old template header from other files at that time.

@facebook-github-bot
Copy link
Contributor

@sagar0 merged this pull request in dda4743.

@sagar0 sagar0 deleted the rm-patents branch May 23, 2019 17:57
vagogte pushed a commit to vagogte/rocksdb that referenced this pull request Jun 18, 2019
Summary:
Remove PATENTS related wording from a few stragglers which still reference the old PATENTS file.
Pull Request resolved: facebook#5326

Differential Revision: D15423297

Pulled By: sagar0

fbshipit-source-id: 4babcddfc120b7d2fed6eb3898287cf8012bf8ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants