Organizing rocksdb/table directory by format #5373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siying
approved these changes
May 29, 2019
TARGETS
Outdated
| "table/blockbased/flush_block_policy.cc", | ||
| "table/blockbased/full_filter_block.cc", | ||
| "table/blockbased/index_builder.cc", | ||
| "table/blockbased/partitioned_filter_block.cc", |
There was a problem hiding this comment.
I don't have opinion on "blockbased" or "block_based" by itself, but since we already call "block_based" in file name, can we keep it consistent?
|
needs to fix cmake. |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@vjnadimpalli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@vjnadimpalli merged this pull request in 50e4707. |
vagogte
pushed a commit
to vagogte/rocksdb
that referenced
this pull request
Jun 18, 2019
Summary: Pull Request resolved: facebook#5373 Differential Revision: D15559425 Pulled By: vjnadimpalli fbshipit-source-id: 5d6d6d615582bedd96a4b879bb25d429a6de8b55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.