New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some memory related files from util/ to memory/ #5382
Conversation
I was thinking about whether we should move it util/memory/ or memory/. And I feel that there might not be a lot of sub-directories under util/ eventually, so it might feel strange. But I don't think it's a big decision to make. We can always move later if people don't like it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Move arena, allocator, and memory tools under util to a separate memory/ directory. Test Plan: run make and cmake
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Move arena, allocator, and memory tools under util to a separate memory/ directory. Pull Request resolved: facebook#5382 Differential Revision: D15564655 Pulled By: siying fbshipit-source-id: 9cd6b5d0d3d52b39606e19221fa154596e5852a5
Summary: Move arena, allocator, and memory tools under util to a separate memory/ directory. Pull Request resolved: facebook/rocksdb#5382 Differential Revision: D15564655 Pulled By: siying fbshipit-source-id: 9cd6b5d0d3d52b39606e19221fa154596e5852a5 Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: Move arena, allocator, and memory tools under util to a separate memory/ directory. Pull Request resolved: facebook/rocksdb#5382 Differential Revision: D15564655 Pulled By: siying fbshipit-source-id: 9cd6b5d0d3d52b39606e19221fa154596e5852a5 Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary:
Move arena, allocator, and memory tools under util to a separate memory/ directory.
Test Plan: run make and cmake