Move some logging related files to logging/ #5387
Conversation
There was a problem hiding this comment.
Thanks @siying. LGTM mostly except a minor comment on header file inclusion order, which should be fixed by a make format.
| @@ -7,13 +7,13 @@ | |||
| // Use of this source code is governed by a BSD-style license that can be | |||
| // found in the LICENSE file. See the AUTHORS file for names of contributors. | |||
|
|
|||
| #include "rocksdb/comparator.h" | |||
There was a problem hiding this comment.
Re-order the headers?
There was a problem hiding this comment.
This is done by our automatic linter.
I believe the linter follows the same order as suggested by Google C++ Style, and I believe it's the same as what our linter made: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
This file is comparator.cc, so it ranked comparator.h to the first.
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@siying has updated the pull request. Re-import the pull request |
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Travis and Appveyor failures are not related. |
Summary: Many logging related source files are under util/. It will be more structured if they are together. Test Plan: Run make and cmake fix
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Many logging related source files are under util/. It will be more structured if they are together. Pull Request resolved: facebook#5387 Differential Revision: D15579036 Pulled By: siying fbshipit-source-id: 3850134ed50b8c0bb40a0c8ae1f184fa4081303f
Summary: Many logging related source files are under util/. It will be more structured if they are together. Pull Request resolved: facebook/rocksdb#5387 Differential Revision: D15579036 Pulled By: siying fbshipit-source-id: 3850134ed50b8c0bb40a0c8ae1f184fa4081303f Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: Many logging related source files are under util/. It will be more structured if they are together. Pull Request resolved: facebook/rocksdb#5387 Differential Revision: D15579036 Pulled By: siying fbshipit-source-id: 3850134ed50b8c0bb40a0c8ae1f184fa4081303f Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: Many logging related source files are under util/. It will be more structured if they are together. Pull Request resolved: facebook/rocksdb#5387 Differential Revision: D15579036 Pulled By: siying fbshipit-source-id: 3850134ed50b8c0bb40a0c8ae1f184fa4081303f Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: Many logging related source files are under util/. It will be more structured if they are together. Pull Request resolved: facebook/rocksdb#5387 Differential Revision: D15579036 Pulled By: siying fbshipit-source-id: 3850134ed50b8c0bb40a0c8ae1f184fa4081303f Signed-off-by: Changlong Chen <levisonchen@live.cn>
Summary: Many logging related source files are under util/. It will be more structured if they are together.
Test Plan: Run make and cmake