Avoid deadlock between mutex_ and log_write_mutex_ #5437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@maysamyabandeh merged this pull request in c8c1a54. |
yizhang82
pushed a commit
that referenced
this pull request
Jun 12, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: #5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a (cherry picked from commit c8c1a54)
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Jun 12, 2019
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7
ajkr
pushed a commit
to cockroachdb/rocksdb
that referenced
this pull request
Jun 14, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: facebook#5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a
ajkr
pushed a commit
to cockroachdb/rocksdb
that referenced
this pull request
Jun 14, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: facebook#5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a
vagogte
pushed a commit
to vagogte/rocksdb
that referenced
this pull request
Jun 18, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: facebook#5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a
ajkr
pushed a commit
to cockroachdb/rocksdb
that referenced
this pull request
Jun 26, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: facebook#5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a
32 tasks
ajkr
pushed a commit
to cockroachdb/rocksdb
that referenced
this pull request
Jun 27, 2019
Summary: To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_. Pull Request resolved: facebook#5437 Differential Revision: D15749722 Pulled By: maysamyabandeh fbshipit-source-id: f57b69c44b4b80cc6d7ddf3d3fdf4a9eb5a5a45a
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Dec 23, 2019
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Mar 17, 2020
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 13, 2020
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: 5b0aa04
facebook-github-bot
pushed a commit
to facebook/mysql-5.6
that referenced
this pull request
Mar 8, 2021
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Differential Revision: D15753718 (603097e) fbshipit-source-id: 4638342286c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Differential Revision: D15753718 (facebook@603097e) fbshipit-source-id: 4638342286c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Differential Revision: D15753718 (facebook@603097e) fbshipit-source-id: 4638342286c
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Differential Revision: D15753718 (facebook@603097e) fbshipit-source-id: 4638342286c
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Nov 1, 2023
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Nov 10, 2023
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 18, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 21, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 26, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Jan 30, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 @update-submodule: rocksdb Differential Revision: D15753718
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 16, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 18, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 29, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 13, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 27, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
May 31, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 5, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 10, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
Upstream commit ID : fb-mysql-5.6.35/603097e97d615c141f21f61b4bf440ad2a40557c PS-6867 : Merge fb-prod201905 Summary: This includes two RocksDB deadlock fixes: 1. Avoid deadlock between mutex_ and log_write_mutex_: facebook/rocksdb#5437 2. WritePrepared: Fix deadlock in WriteRecoverableState: facebook/rocksdb#5306 update-submodule: rocksdb Reviewed By: hermanlee Differential Revision: D15753718 fbshipit-source-id: ec6b9b7e381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid deadlock mutex_ should never be acquired before log_write_mutex_. The patch documents that and also fixes one case in ::FlushWAL that acquires mutex_ through ::WriteStatusCheck when it already holds lock on log_write_mutex_.