Disable snapshot refresh feature when snap_refresh_nanos is 0 #5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
maysamyabandeh
force-pushed
the
fix-refresh-0
branch
from
79a7ec5
to
22b26e0
Compare
|
@maysamyabandeh has updated the pull request. Re-import the pull request |
maysamyabandeh
force-pushed
the
fix-refresh-0
branch
from
22b26e0
to
c57334f
Compare
|
@maysamyabandeh has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@maysamyabandeh has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I didn't see "test plan" in PR summary. What's your test plan? |
siying
approved these changes
Aug 20, 2019
|
The added assert statement is the test plan. It caught the existing bug and also another one in the unit tests where snap_refresh_time_ was set to zero, interpreting that as no delay instead of disabled feature. |
|
@maysamyabandeh OK then. |
|
@maysamyabandeh merged this pull request in 7bc18e2. |
maysamyabandeh
pushed a commit
that referenced
this pull request
Aug 20, 2019
Summary: The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: #5278 The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero. Pull Request resolved: #5724 Differential Revision: D16918185 Pulled By: maysamyabandeh fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
maysamyabandeh
pushed a commit
that referenced
this pull request
Aug 20, 2019
Summary: The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: #5278 The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero. Pull Request resolved: #5724 Differential Revision: D16918185 Pulled By: maysamyabandeh fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
maysamyabandeh
pushed a commit
that referenced
this pull request
Sep 17, 2019
Summary: The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: #5278 The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero. Pull Request resolved: #5724 Differential Revision: D16918185 Pulled By: maysamyabandeh fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
maysamyabandeh
pushed a commit
that referenced
this pull request
Sep 18, 2019
Summary: The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: #5278 The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero. Pull Request resolved: #5724 Differential Revision: D16918185 Pulled By: maysamyabandeh fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
maysamyabandeh
pushed a commit
to maysamyabandeh/rocksdb
that referenced
this pull request
Sep 18, 2019
Revert "Allow users to stop manual compactions (facebook#3971)" This reverts commit 6226830. Deprecate snap_refresh_nanos feature Revert "Disable snapshot refresh feature when snap_refresh_nanos is 0 (facebook#5724)" This reverts commit dd757ff. Revert "Declare snapshot refresh incompatible with delete range (facebook#5625)" This reverts commit fdc56e2. Revert "Disable refresh snapshot feature by default (facebook#5606)" This reverts commit cfd6eb3. Revert snapshot refresh feature deprecate the option Revert "Revert "Allow users to stop manual compactions (facebook#3971)"" This reverts commit 6194c8f70b141899f66d777a7b1749ac346770c4.
merryChris
pushed a commit
to merryChris/rocksdb
that referenced
this pull request
Nov 18, 2019
…ok#5724) Summary: The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: facebook#5278 The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero. Pull Request resolved: facebook#5724 Differential Revision: D16918185 Pulled By: maysamyabandeh fbshipit-source-id: fec167287df7d85093e087fc39c0eb243e3bbd7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments of snap_refresh_nanos advertise that the snapshot refresh feature will be disabled when the option is set to 0. This contract is however not honored in the code: #5278
The patch fixes that and also adds an assert to ensure that the feature is not used when the option is zero.