Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test showing range tombstones can create excessively large compactions #5956

Closed
wants to merge 5 commits into from
Closed

Add test showing range tombstones can create excessively large compactions #5956

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be21b75
Range tombstones can create excessively large compactions
Oct 22, 2019
8e74e7f
Range tombstones can create excessively large compactions
Oct 22, 2019
3989bda
updated based off review comments
Oct 23, 2019
9ccf29e
updated based off review comments2
Oct 23, 2019
b1a9e07
Merge branch 'master' into overlapped-tombstone
dlambrig Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions db/db_range_del_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,6 +1521,88 @@ TEST_F(DBRangeDelTest, RangeTombstoneWrittenToMinimalSsts) {
ASSERT_EQ(1, num_range_deletions);
}

TEST_F(DBRangeDelTest, OverlappedTombstones) {
const int kNumPerFile = 4, kNumFiles = 2;
Options options = CurrentOptions();
options.disable_auto_compactions = true;
options.max_compaction_bytes = 9*1024;
dlambrig marked this conversation as resolved.
Show resolved Hide resolved
options.db_log_dir = "/tmp";
dlambrig marked this conversation as resolved.
Show resolved Hide resolved
DestroyAndReopen(options);
// snapshot prevents key from being deleted during flush
const Snapshot* snapshot = db_->GetSnapshot();
dlambrig marked this conversation as resolved.
Show resolved Hide resolved
Random rnd(301);
for (int i = 0; i < kNumFiles; ++i) {
std::vector<std::string> values;
// Write 12K (4 values, each 3K)
for (int j = 0; j < kNumPerFile; j++) {
values.push_back(RandomString(&rnd, 3 << 10));
ASSERT_OK(Put(Key(i * kNumPerFile + j), values[j]));
}
}
ASSERT_OK(db_->Flush(FlushOptions()));
ASSERT_EQ(1, NumTableFilesAtLevel(0));
MoveFilesToLevel(2);
ASSERT_EQ(2, NumTableFilesAtLevel(2));

ASSERT_OK(db_->DeleteRange(WriteOptions(), db_->DefaultColumnFamily(), Key(1), Key((kNumFiles) *kNumPerFile+1)));
ASSERT_OK(db_->Flush(FlushOptions()));

// The tombstone range is not broken up into multiple SSTs which may incur a large compaction with L2.
dlambrig marked this conversation as resolved.
Show resolved Hide resolved
ASSERT_EQ(1, NumTableFilesAtLevel(0));

dbfull()->TEST_CompactRange(0, nullptr, nullptr, nullptr,
true /* disallow_trivial_move */);
ASSERT_EQ(1, NumTableFilesAtLevel(1));
std::vector<std::vector<FileMetaData>> files;
dbfull()->TEST_CompactRange(1, nullptr, nullptr, nullptr,
true /* disallow_trivial_move */);
ASSERT_EQ(1, NumTableFilesAtLevel(2));
ASSERT_EQ(0, NumTableFilesAtLevel(1));
db_->ReleaseSnapshot(snapshot);
}

TEST_F(DBRangeDelTest, OverlappedKeys) {
const int kNumPerFile = 4, kNumFiles = 2;
Options options = CurrentOptions();
options.disable_auto_compactions = true;
options.max_compaction_bytes = 9*1024;
options.db_log_dir = "/tmp";
DestroyAndReopen(options);
// snapshot prevents key from being deleted during flush
const Snapshot* snapshot = db_->GetSnapshot();
Random rnd(301);
for (int i = 0; i < kNumFiles; ++i) {
std::vector<std::string> values;
// Write 12K (4 values, each 3K)
for (int j = 0; j < kNumPerFile; j++) {
values.push_back(RandomString(&rnd, 3 << 10));
ASSERT_OK(Put(Key(i * kNumPerFile + j), values[j]));
}
}
ASSERT_OK(db_->Flush(FlushOptions()));
ASSERT_EQ(1, NumTableFilesAtLevel(0));
MoveFilesToLevel(2);
ASSERT_EQ(2, NumTableFilesAtLevel(2));

for (int i=1;i<kNumFiles *kNumPerFile+1;i++) {
ASSERT_OK(Put(Key(i), "0x123"));
}
ASSERT_OK(db_->Flush(FlushOptions()));
ASSERT_EQ(1, NumTableFilesAtLevel(0));

// The key range is broken up into three SSTs to avoid a future big compaction with the grandparent
dbfull()->TEST_CompactRange(0, nullptr, nullptr, nullptr,
true /* disallow_trivial_move */);
ASSERT_EQ(3, NumTableFilesAtLevel(1));

std::vector<std::vector<FileMetaData>> files;
dbfull()->TEST_CompactRange(1, nullptr, nullptr, nullptr,
true /* disallow_trivial_move */);
ASSERT_EQ(1, NumTableFilesAtLevel(2));
ASSERT_EQ(0, NumTableFilesAtLevel(1));
db_->ReleaseSnapshot(snapshot);
}

#endif // ROCKSDB_LITE

} // namespace rocksdb
Expand All @@ -1530,3 +1612,4 @@ int main(int argc, char** argv) {
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}