Add PauseBackgroundWork() to db_stress #6148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Worker thread will occasionally call PauseBackgroundWork(), briefly sleep (to avoid stalling itself) and then call ContinueBackgroundWork(). Test Plan: some running of 'make blackbox_crash_test' with temporary printf output to confirm code occasionally reached.
pdillinger
force-pushed
the
db_stress_pause_background
branch
from
e09a5cd
to
41cb7ef
Compare
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
anand1976
approved these changes
Dec 10, 2019
| @@ -613,6 +613,28 @@ void StressTest::OperateDb(ThreadState* thread) { | |||
| } | |||
| } | |||
|
|
|||
| if (FLAGS_pause_background_one_in > 0 && | |||
| thread->rand.OneIn(FLAGS_pause_background_one_in)) { | |||
There was a problem hiding this comment.
Elsewhere in OperateDb(), we use thread->rand.Uniform(). What's the difference?
There was a problem hiding this comment.
The others are just silly for not using the simpler API
siying
approved these changes
Dec 10, 2019
| if (!status.ok()) { | ||
| VerificationAbort(shared, "ContinueBackgroundWork status not OK", | ||
| status); | ||
| } |
There was a problem hiding this comment.
OperateDb() function is long. Can we create a separate function like TestPauseBackgrounWork() for that?
There was a problem hiding this comment.
There are more pieces that should get the same treatment, so I'll roll that into another PR for hygienic updates.
|
@pdillinger merged this pull request in a653857. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 19, 2019
Summary: Complete some refactoring called for in #6148. Somehow I got some 'make format' in here for files I didn't change, but that should be OK. (I'm not sure why "hide whitespace changes" doesn't seem to help in review.) Not addressed in this PR: some operations simply print to stdout rather than failing on discovering a bad status or inconsistency. Pull Request resolved: #6195 Differential Revision: D19131067 Pulled By: pdillinger fbshipit-source-id: 4f416e6b792023989ef119f385fe122426cb825d
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
Summary: Worker thread will occasionally call PauseBackgroundWork(), briefly sleep (to avoid stalling itself) and then call ContinueBackgroundWork(). Pull Request resolved: facebook#6148 Test Plan: some running of 'make blackbox_crash_test' with temporary printf output to confirm code occasionally reached. Differential Revision: D18913886 Pulled By: pdillinger fbshipit-source-id: ae9356a803390929f3165dfb6a00194692ba92be
wolfkdy
pushed a commit
to wolfkdy/rocksdb
that referenced
this pull request
Dec 22, 2019
Summary: Complete some refactoring called for in facebook#6148. Somehow I got some 'make format' in here for files I didn't change, but that should be OK. (I'm not sure why "hide whitespace changes" doesn't seem to help in review.) Not addressed in this PR: some operations simply print to stdout rather than failing on discovering a bad status or inconsistency. Pull Request resolved: facebook#6195 Differential Revision: D19131067 Pulled By: pdillinger fbshipit-source-id: 4f416e6b792023989ef119f385fe122426cb825d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Worker thread will occasionally call PauseBackgroundWork(),
briefly sleep (to avoid stalling itself) and then call
ContinueBackgroundWork().
Test Plan: some running of 'make blackbox_crash_test' with temporary
printf output to confirm code occasionally reached.