Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rocksdb_transactiondb_* to C binding #6287

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lbguilherme
Copy link

@lbguilherme lbguilherme commented Jan 12, 2020

I noticed some rocksdb_transactiondb_* are missing from c.cc. This patch adds:

  • rocksdb_transactiondb_drop_column_family
  • rocksdb_transactiondb_property_value
  • rocksdb_transactiondb_property_int
  • rocksdb_transactiondb_property_int_cf
  • rocksdb_transactiondb_property_value_cf
  • rocksdb_transactiondb_approximate_sizes
  • rocksdb_transactiondb_approximate_sizes_cf

@facebook-github-bot
Copy link
Contributor

Hi lbguilherme! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lbguilherme lbguilherme force-pushed the feat/add-c-rocksdb_transactiondb_drop_column_family branch from ff63434 to ff66dac Compare January 12, 2020 14:45
@lbguilherme lbguilherme force-pushed the feat/add-c-rocksdb_transactiondb_drop_column_family branch from ff66dac to 2de4a80 Compare January 12, 2020 14:46
@lbguilherme
Copy link
Author

CI failed with "Build execution time has reached the maximum allowed time for your plan (90 minutes).". Doesn't seem related to this change.

@lbguilherme lbguilherme changed the title Add C binding rocksdb_transactiondb_drop_column_family Add missing rocksdb_transactiondb_* to C binding Jan 13, 2020
@anand1976
Copy link
Contributor

Can you add these to db/c_test.c so they get exercised?

@lbguilherme
Copy link
Author

lbguilherme commented Jan 26, 2020

@anand1976 Added tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants