Reduce runtime of db_with_timestamp_basic_test #6546
Conversation
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks for making the changes! LGTM. |
Summary: Reduce runtime by reducing test scale. Test Plan: time ./db_with_timestamp_basic_test
riversand963
force-pushed
the
shorter-tests
branch
from
8123ecf
to
c8999f7
Compare
|
@riversand963 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Travis error is not related. |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Yeah, I checked the Travis, the error comes from table/block_based/partitioned_index_iterator.cc. Not related to the current PR. |
Yeah, proposed a fix in #6547 |
Should I take a look? |
Feel free to do so, and thanks! |
There was a problem hiding this comment.
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@riversand963 merged this pull request in 66ed580. |
Summary:
Reduce runtime by reducing test scale to avoid test time-outs.
Test Plan:
time ./db_with_timestamp_basic_test
and watch internal tests.