Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass a timeout to FileSystem for random reads #6751

Closed
wants to merge 3 commits into from
Closed

Pass a timeout to FileSystem for random reads #6751

wants to merge 3 commits into from

Commits on Apr 30, 2020

  1. Calculate a timeout from ReadOptions.deadline to be passed to 

    FileSystem::Read/FileSystem::MultiRead. For now, TableReader creation,
whichmight do file opens and reads, are not covered. It will be
implemented in another PR.

Pass ReadOptions to RandomAccessFileReader::Read and MultiRead

Pass timeout down to FileSystem

Update tests

Add some comments in tests
    anand76 committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    4c5c34f View commit details
    Browse the repository at this point in the history

  2. Fix CircleCI build errors

    anand76 committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    026c3cd View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Summary:
1. Pass IOOptions to RandomAccessFileReader::Read and MultiRead instead
of ReadOptions
2. Use SpecialEnv in unit tests to fake time
    anand76 committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    a45f154 View commit details
    Browse the repository at this point in the history