Slightly expand converage to file consistency check failure #6800
Conversation
Summary: Current DBCompactionTest.ConsistencyFailTest checks DB fails after L0 inconsitency is found. Add slightly more coverage by introducing DBCompactionTest.ConsistencyFailTest2 which checks non-L0 files too. Test Plan: Run the new test.
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
db/version_builder.cc
Outdated
| auto pair = std::make_pair(&f1, &f2); | ||
| TEST_SYNC_POINT_CALLBACK("VersionBuilder::CheckConsistency", &pair); | ||
| auto pair = std::make_pair(&f1, &f2); | ||
| TEST_SYNC_POINT_CALLBACK("VersionBuilder::CheckConsistency1", &pair); |
There was a problem hiding this comment.
Nit: How about CheckConsistencyL0.
db/version_builder.cc
Outdated
| @@ -279,6 +279,10 @@ class VersionBuilder::Rep { | |||
| NumberToString(f2->fd.GetNumber())); | |||
| } | |||
| } else { | |||
| #ifndef NDEBUG | |||
| auto pair = std::make_pair(&f1, &f2); | |||
| TEST_SYNC_POINT_CALLBACK("VersionBuilder::CheckConsistency2", &pair); | |||
There was a problem hiding this comment.
How about CheckConsistencyNonL0
| // to determine the DB is frozen. | ||
| dbfull()->TEST_WaitForCompact(); | ||
| ASSERT_NOK(Put("foo", "bar")); | ||
| ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); |
There was a problem hiding this comment.
Might be safer to clear all callbacks somewhere.
|
@siying has updated the pull request. Re-import the pull request |
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request has been merged in c21c459. |
Summary: Current DBCompactionTest.ConsistencyFailTest checks DB fails after L0 inconsitency is found. Add slightly more coverage by introducing DBCompactionTest.ConsistencyFailTest2 which checks non-L0 files too.
Test Plan: Run the new test.