Allow missing "unversioned" python, as in CentOS 8 #6883
Conversation
Summary: RocksDB Makefile was assuming existence of 'python' command, which is not present in CentOS 8. We fall back on python3 now. Also, now use 'python' for PYTHON if not found so that an informative "command not found" error will result rather than something weird. Test Plan: manually tried some variants
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Zitan found that format-diff.sh still runs "python" for clang-format-diff.py. Trying to determine best way to resolve |
|
@pdillinger has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Thanks! (also tested on a vm with CentOS 8) |
There was a problem hiding this comment.
@gg814 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in 0c56fc4. |
Summary: RocksDB Makefile was assuming existence of 'python' command,
which is not present in CentOS 8. We avoid using 'python' if 'python3' is available.
Also added fancy logic to format-diff.sh to make clang-format-diff.py for Python2 work even with Python3 only (as some CentOS 8 FB machines come equipped)
Also, now use just 'python3' for PYTHON if not found so that an informative
"command not found" error will result rather than something weird.
Test Plan: manually tried some variants, 'make check' on a fresh CentOS 8 machine without 'python' executable or Python2 but with clang-format-diff.py for Python2.