build fixes for GNU/kFreeBSD #6992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zhichao-cao
approved these changes
Jun 18, 2020
|
Thanks for reviewing! |
|
Status update: we still carry this patch downstream in https://salsa.debian.org/mariadb-team/mariadb-10.5/-/blob/master/debian/patches/rocksdb-kfreebsd.patch by @jrtc27. Seems the commit 312f23c has not yet been tagged to be part of any release, and we need to keep waiting until this fix is shipped officially despite the merge was done in June. |
|
@ottok Looks to me like this is in the 6.13.fb branch, and so will be included in an upcoming release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream https://salsa.debian.org/mariadb-team/mariadb-10.4/-/blob/master/debian/patches/rocksdb-kfreebsd.patch
by @jrtc27.
Fixes #5223.