Add a stress test to test read after write correctness #7106
Conversation
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Current stress tests don't have enough coverage to validate correctness for consistency for read after concurrent writes. Add one stress test to provide more coverage. The idea is to have all workloads to be mathematically determined, so that the DB state can be calculated based on one single incremental counter. This can help reduce other factors for the thread synchronization. While tests without snapshtos are passsing, tests With snapshots tests sometimes fail for reason unknown. Will keep debugging. Although multiple db_stress options are supported here, crash_test still cannot run against this test as crash/recovery is not supported yet. Test Plan: ./db_stress -test_read_after_write --acquire_snapshot_one_in=3 ./db_stress -test_read_after_write
|
@siying has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@siying has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Hi @siying! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
Current stress tests don't have enough coverage to validate correctness for consistency for read after concurrent writes. Add one stress test to provide more coverage. The idea is to have all workloads to be mathematically determined, so that the DB state can be calculated based on one single incremental counter. This can help reduce other factors for the thread synchronization.
Although multiple db_stress options are supported here, crash_test still cannot run against this test as crash/recovery is not supported yet.
Test Plan:
./db_stress -test_read_after_write --acquire_snapshot_one_in=3
./db_stress -test_read_after_write