Shutdown timer in destructor #7292
Conversation
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| [&] { mock_env_->set_current_time(mock_time_sec); }); | ||
|
|
||
| // delete a running timer should not cause any exception | ||
| delete timer_ptr; |
There was a problem hiding this comment.
When deleting the timer, fn_sch_test may or may not be running, so maybe test two cases separately?
There was a problem hiding this comment.
Added another test for deleting a timer with running function (similar to shutdown running function test).
Make sure deleting a running timer is fine. Test Plan: unittest and an invalid benchmark command: `./db_bench --db=/tmp --use_existing_db=false --benchmarks=fred --compression_type=none`
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jay-zhuang merged this pull request in e500c73. |
Summary: Make sure deleting a running timer works fine. Pull Request resolved: facebook#7292 Test Plan: unittest and an invalid benchmark command: `./db_bench --db=/tmp --use_existing_db=false --benchmarks=fred --compression_type=none` Reviewed By: riversand963 Differential Revision: D23248500 Pulled By: jay-zhuang fbshipit-source-id: 04111681b389a9aa23a439db4568d5ca351f1144
Make sure deleting a running timer works fine.
Test Plan: unittest and an invalid benchmark command:
./db_bench --db=/tmp --use_existing_db=false --benchmarks=fred --compression_type=none