Fix/minimize mock_time_env.h dependencies #7426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: (a) own copy of kMicrosInSecond (b) out-of-line sync point code Test Plan: FB internal
mrambacher
approved these changes
Sep 22, 2020
CMakeLists.txt
Outdated
| @@ -731,6 +731,7 @@ set(SOURCES | |||
| table/table_factory.cc | |||
| table/table_properties.cc | |||
| table/two_level_iterator.cc | |||
| test_util/mock_time_env.cc | |||
There was a problem hiding this comment.
Shouldn't this be in TEST_LIB_SOURCES and not LIB_SOURCES?
There was a problem hiding this comment.
I was just copying from sync_point.cc. I'll try it and see if I have difficulty working out the public as well as internal dependencies.
There was a problem hiding this comment.
Maybe TESTUTIL_SOURCE for cmake.
src.mk
Outdated
| @@ -178,6 +178,7 @@ LIB_SOURCES = \ | |||
| table/table_factory.cc \ | |||
| table/table_properties.cc \ | |||
| table/two_level_iterator.cc \ | |||
| test_util/mock_time_env.cc \ | |||
| @@ -62,29 +64,11 @@ class MockTimeEnv : public EnvWrapper { | |||
| // TODO: this is a workaround for the different behavior on different platform | |||
| // for timedwait timeout. Ideally timedwait API should be moved to env. | |||
| // details: PR #7101. | |||
| void InstallTimedWaitFixCallback() { | |||
There was a problem hiding this comment.
Should the methods that use std::numeric_limits also be moved or should be included?
There was a problem hiding this comment.
env.h -> limits is sufficient
jay-zhuang
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pdillinger merged this pull request in ac1734d. |
pdillinger
added a commit
that referenced
this pull request
Sep 23, 2020
Summary: (a) own copy of kMicrosInSecond (b) out-of-line sync point code Pull Request resolved: #7426 Test Plan: FB internal Reviewed By: ajkr Differential Revision: D23861363 Pulled By: pdillinger fbshipit-source-id: de6b1621dca2f7391c5ff72bad04a7613dc27527
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: (a) own copy of kMicrosInSecond (b) out-of-line sync point code Pull Request resolved: facebook#7426 Test Plan: FB internal Reviewed By: ajkr Differential Revision: D23861363 Pulled By: pdillinger fbshipit-source-id: de6b1621dca2f7391c5ff72bad04a7613dc27527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: (a) own copy of kMicrosInSecond
(b) out-of-line sync point code
Test Plan: FB internal