[circleci] Remove a gtest-parallel workaround #7433
Conversation
As the issue is fixed in official repo: google/gtest-parallel#79
jay-zhuang
force-pushed
the
cc_test2
branch
from
54bfd66
to
9bae3fa
Compare
jay-zhuang
changed the title
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
.circleci/config.yml
Outdated
| @@ -337,7 +336,7 @@ jobs: | |||
| sed -i 's/[[:space:]]*$//; s/ / \.\//g; s/.*/.\/&/' /tmp/test_list | |||
| cat /tmp/test_list | |||
| export TEST_TMPDIR=/tmp/rocksdb_test_tmp | |||
| /usr/bin/python ../gtest-parallel/gtest-parallel $(</tmp/test_list) --output_dir=/tmp --print_task_status_continuously | |||
| /usr/bin/python ../gtest-parallel/gtest-parallel $(</tmp/test_list) --output_dir=/tmp | cat | |||
There was a problem hiding this comment.
This doesn't matter, just for my understanding -- do we lose color support by tricking the python program into thinking it's not a tty?
There was a problem hiding this comment.
I'll add comment on that.
We won't lose color support with cat, it's just to output job status continuously.
Without that, it won't print anything while running on circleci output, because the gtest_parallel script try to re-use the same line for status update, and on web-ui it doesn't print anything.
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jay-zhuang merged this pull request in 58905f3. |
Summary: As the issue is fixed in official repo: google/gtest-parallel#79 Pull Request resolved: facebook#7433 Reviewed By: ajkr Differential Revision: D24023271 Pulled By: jay-zhuang fbshipit-source-id: 0babf5e4c59cd61ded5a64cf9aa2d457deeeaa47
As the issue is fixed in official repo:
google/gtest-parallel#79