Add trace_analyzer_test to ASSERT_STATUS_CHECKED list #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riversand963
approved these changes
Sep 30, 2020
There was a problem hiding this comment.
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mrambacher
reviewed
Sep 30, 2020
| @@ -1428,7 +1429,7 @@ Status TraceAnalyzer::OpenStatsOutputFiles(const std::string& type, | |||
| &new_stats.a_qps_f); | |||
| } | |||
|
|
|||
| return Status::OK(); | |||
| return s; | |||
There was a problem hiding this comment.
That entire method is kind of screwy. It keeps calling Open over and over again and never checking the Status. Of course, if the status was not OK, the program will exit. I am not sure what is best to do here.
zhichao-cao
force-pushed
the
status_analyzer
branch
from
4aa9836
to
248991f
Compare
|
@zhichao-cao has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zhichao-cao merged this pull request in 685cabd. |
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: Add trace_analyzer_test to ASSERT_STATUS_CHECKED list Pull Request resolved: facebook#7480 Test Plan: ASSERT_STATUS_CHECKED=1 make -j48 trace_analyzer_test Reviewed By: riversand963 Differential Revision: D24033768 Pulled By: zhichao-cao fbshipit-source-id: b415045e6fab01d6193448650772368c21c6dba6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary: Add trace_analyzer_test to ASSERT_STATUS_CHECKED list
test plan: ASSERT_STATUS_CHECKED=1 make -j48 trace_analyzer_test