Small improvements to CircleCI Windows jobs #7852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adamretter
commented
Jan 10, 2021
adamretter
commented
- Clearer indication of which versions of msbuild and Visual Studio is used
- Explicit naming of the build jobs within the Windows workflows
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
akankshamahajan15
approved these changes
Jan 11, 2021
jay-zhuang
reviewed
Jan 11, 2021
.circleci/config.yml
Outdated
| @@ -392,6 +396,7 @@ jobs: | |||
| cd build | |||
| ${CMAKE_BIN} -G "${CMAKE_GENERATOR}" -DCMAKE_BUILD_TYPE=Debug -DOPTDBG=1 -DPORTABLE=1 -DSNAPPY=1 -DJNI=1 << parameters.extra_cmake_opt >> .. | |||
| cd .. | |||
| msbuild.exe /version | |||
There was a problem hiding this comment.
Seems msbuild.exe version is always the same for all builds (either 2015 or 2019, etc.), and it already displays the version information:
Microsoft (R) Build Engine version 16.8.2+25e4d540b for .NET Framework
I don't think this line is necessary, and it's causing an error:
MSBUILD : error MSB1009: Project file does not exist.
Maybe we could change it to:
echo "Building with VS version: ${CMAKE_GENERATOR}"
|
@adamretter has updated the pull request. You must reimport the pull request before landing. |
There was a problem hiding this comment.
@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jay-zhuang merged this pull request in e4bdf9e. |
codingrhythm
pushed a commit
to SafetyCulture/rocksdb
that referenced
this pull request
Mar 5, 2021
Summary: * Clearer indication of which versions of msbuild and Visual Studio is used * Explicit naming of the build jobs within the Windows workflows Pull Request resolved: facebook#7852 Reviewed By: akankshamahajan15 Differential Revision: D25864444 Pulled By: jay-zhuang fbshipit-source-id: 0d618ad8a8892d5a2575cdfaa59d61a989c4df4b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.