Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp check_format_compatible.sh #8012

Closed

Commits on Mar 1, 2021

  1. Revamp check_format_compatible.sh

    Summary:
    * Adds backup/restore forward/backward compatibility testing
    * Adds forward/backward compatibility testing to sst ingestion
    * More structure sharing and comments for the lists of branches
    comprising each group
    * Less reliant on invariants between groups with de-duplication logic
    * Restructured for n+1 branch checkout+build steps rather than something
    like 3n. Should be much faster despite more checks.
    
    And to make manual runs easier
    
    * On success, restores working trees to original working branch (aborts
    early if uncommitted changes) and deletes temporary branch & remote
    * Adds SHORT_TEST=1 mode that uses only the oldest version for each
    * Adds USE_SSH=1 to use ssh instead of https for github
    group
    
    Test Plan: a number of manual tests, mostly with SHORT_TEST=1. Using one
    version older for any of the groups (except I didn't check
    db_backward_only_refs) fails. Changing default format_version to 5
    (planned) without updating this script fails as it should, and passes
    with appropriate update. TODO: full local run
    pdillinger committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    48e0aec View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Improve usability

    pdillinger committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    a7c7180 View commit details
    Browse the repository at this point in the history
  2. Fix lints

    pdillinger committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0e59cc4 View commit details
    Browse the repository at this point in the history