Apply sample_for_compression to all block-based tables
#8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it only applied to files generated by flush. This restriction was undocumented and blocked a new use case. Now compression sampling applies to all files we generate when it is enabled. Test Plan: new unit test
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ajkr
changed the title
sample_for_compression to all filessample_for_compression to all block-based tables
riversand963
approved these changes
Mar 25, 2021
db/db_properties_test.cc
Outdated
| return Status::OK(); | ||
| } | ||
|
|
||
| void BlockAdd(uint64_t /* blockRawBytes */, uint64_t blockCompressedBytesFast, |
There was a problem hiding this comment.
Nit: block_compressed_bytes_fast and block_compressed_bytes_slow?
To make the linter happy, we need to update the variable name in TablePropertiesCollector::BlockAdd() too.
|
@ajkr has updated the pull request. You must reimport the pull request before landing. |
ajkr
commented
Mar 25, 2021
db/db_properties_test.cc
Outdated
| return Status::OK(); | ||
| } | ||
|
|
||
| void BlockAdd(uint64_t /* blockRawBytes */, uint64_t blockCompressedBytesFast, |
|
@ajkr has updated the pull request. You must reimport the pull request before landing. |
|
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it only applied to block-based tables generated by flush. This restriction
was undocumented and blocked a new use case. Now compression sampling
applies to all block-based tables we generate when it is enabled.
Test Plan: new unit test