Fix compression dictionary sampling with dedicated range tombstone SSTs #8141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early in case there are zero data blocks when
BlockBasedTableBuilder::EnterUnbuffered()
is called. This crash canonly be triggered by applying dictionary compression to SST files that
contain only range tombstones. It cannot be triggered by a low buffer
limit alone since we only consider entering unbuffered mode after
buffering a data block causing the limit to be breached, or
Finish()
ing the file. It also cannotbe triggered by a totally empty file because those go through
Abandon()
rather thanFinish()
so unbuffered mode is never entered.Test Plan: added a unit test that repro'd the "Floating point exception"