New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions #8158
Update installation instructions #8158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After repeating the "yum" command to install libzstd-devel on my CentOS 8 machine, I think we can not assume yum is available on CentOS 8. It may be available on some for compatibility reasons, but a counter example clearly exists.
@shoda-tibco has updated the pull request. You must reimport the pull request before landing. |
Thanks @shoda-tibco for improving the documentation! |
@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Updated instructions for installing zstd on CentOS and note about clang-format dependency