Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation instructions #8158

Closed

Conversation

shoda-tibco
Copy link
Contributor

Updated instructions for installing zstd on CentOS and note about clang-format dependency

Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@riversand963 riversand963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After repeating the "yum" command to install libzstd-devel on my CentOS 8 machine, I think we can not assume yum is available on CentOS 8. It may be available on some for compatibility reasons, but a counter example clearly exists.

@facebook-github-bot
Copy link
Contributor

@shoda-tibco has updated the pull request. You must reimport the pull request before landing.

@riversand963
Copy link
Contributor

Thanks @shoda-tibco for improving the documentation!

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ajkr merged this pull request in 6db3af1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants