-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose write buffer manager memory usage methods through Java Api #8194
base: main
Are you sure you want to change the base?
expose write buffer manager memory usage methods through Java Api #8194
Conversation
54d4b12
to
2b23ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks fine. I am not certain about the call to make_shared
though. Also this needs tests please?
JNIEnv* /*env*/, jclass /*jclazz*/, jlong jbuffer_size) { | ||
auto* write_buffer_manager = | ||
new std::shared_ptr<ROCKSDB_NAMESPACE::WriteBufferManager>( | ||
std::make_shared<ROCKSDB_NAMESPACE::WriteBufferManager>(jbuffer_size, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this make_shared
is supported in C++14?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm not an expert of C++, and had some troubles to setup the toolchain on my machine, I'll fix this
I could use some help to solve failing tests, I'm not familiar with JNI/Cpp binding:
|
No description provided.