Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle return code by io_uring_submit_and_wait() and io_uring_wait_cqe() #8311

Closed
wants to merge 7 commits into from
Closed

Handle return code by io_uring_submit_and_wait() and io_uring_wait_cqe() #8311

wants to merge 7 commits into from

Commits on May 18, 2021

  1. Handle return code by io_uring_submit_and_wait() and io_uring_wait_cq… 

    …e().

Summary:
Right now return codes by io_uring_submit_and_wait() and io_uring_wait_cqe() are not handled. It is not the good practice. Although these two functions are not supposed to return non-0 values in normal exeuction, people suspect that they might return non-0 value when an interruption happens, and the code might cause hanging.

Test Plan: Make sure at least normal test cases still pass.
    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    08683ee View commit details
    Browse the repository at this point in the history

  2. Fix a bug

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    f50869d View commit details
    Browse the repository at this point in the history

  3. Another fix

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    93293e8 View commit details
    Browse the repository at this point in the history

  4. Add unit tests to handle those failure handling logics.

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    f3522a1 View commit details
    Browse the repository at this point in the history

  5. Improve comments.

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    a8e92ad View commit details
    Browse the repository at this point in the history

  6. Always call io_uring_cqe_seen() as long as cqe is not empty.

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    99aa685 View commit details
    Browse the repository at this point in the history

  7. Disable new tests if IO Uring is not available.

    @siying
    siying committed May 18, 2021
    Configuration menu
    Copy the full SHA
    4219ed5 View commit details
    Browse the repository at this point in the history