-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Merge with Integrated BlobDB in stress, crash and db_bench #8461
Run Merge with Integrated BlobDB in stress, crash and db_bench #8461
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Could you add an entry to the changelog calling out the new |
Summary: Run Merge with Intergrated BlobDB in stress tests, crash tests and db_bench. Test Plan: 1. python3 -u tools/db_crashtest.py --simple whitebox ---use_merge=1 --enable_blob_files=1 2. ./db_bench --benchmarks="readwhilemerging" --merge_operator=uint64add --enable_blob_files=true Reviewers: Subscribers: Tasks: Tags:
666195d
to
1dfb5f5
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
1dfb5f5
to
0367f9c
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@akankshamahajan15 merged this pull request in be8199c. |
Summary: Run Merge with Intergrated BlobDB in stress tests, crash tests and db_bench.
Test Plan: 1. python3 -u tools/db_crashtest.py --simple whitebox
---use_merge=1 --enable_blob_files=1
2. ./db_bench --benchmarks="readwhilemerging"
--merge_operator=uint64add --enable_blob_files=true
Reviewers:
Subscribers:
Tasks:
Tags: