Cache warming blocks during flush #8561
Conversation
akankshamahajan15
force-pushed
the
cache_warming
branch
2 times, most recently
from
6c19375
to
56e1eed
Compare
|
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| if (type == kNoCompression) { | ||
| s = InsertBlockInCache(block_contents, handle); | ||
| s = InsertBlockInCache(block_contents, handle, block_entry, |
There was a problem hiding this comment.
Do we insert all block types or just index/filter/data?
There was a problem hiding this comment.
@anand1976 It currently inserts all block types. I wasn't sure about other blocks and their impact in terms of caching them so I inserted them also. Do we need them or they can be ignored? BlockBasedTableReader doesn't cache them and those blocks are used only once during opening the table so they can be ignored.
There was a problem hiding this comment.
@akankshamahajan15 They can be ignored, except for uncompression dict. I don't think BlockBasedTableReader even looks in the cache for other block types.
akankshamahajan15
force-pushed
the
cache_warming
branch
from
56e1eed
to
6e4b515
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
akankshamahajan15
force-pushed
the
cache_warming
branch
from
a289e09
to
7d13a82
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
akankshamahajan15
force-pushed
the
cache_warming
branch
from
7d13a82
to
d78b764
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
akankshamahajan15
force-pushed
the
cache_warming
branch
from
d78b764
to
111cb5b
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
akankshamahajan15
changed the title
|
@akankshamahajan15 merged this pull request in 8b2f60b. |
Summary: Insert warm blocks (data, uncompressed dict, index and filter blocks) during flush in Block cache which is enabled under option BlockBasedTableOptions.prepopulate_block_cache. Pull Request resolved: facebook#8561 Test Plan: Added unit test Reviewed By: anand1976 Differential Revision: D29773411 Pulled By: akankshamahajan15 fbshipit-source-id: 6631123c10134340ef0bd7e90baafaa6deba0e66 # Conflicts: # HISTORY.md
Summary: Insert warm blocks (data, uncompressed dict, index and filter blocks) during flush in Block cache which is enabled under option BlockBasedTableOptions.prepopulate_block_cache.
Test Plan: Added unit test
Reviewers:
Subscribers:
Tasks:
Tags: