Fix insecure internal API for GetImpl #8590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Calling the GetImpl function could leave reference to a local callback function in a field of a parameter struct. As this is performance-critical code, I'm not going to attempt to sanitize this code too much, but make the existing hack a bit cleaner by reverting what it overwrites in the input struct. Added SaveAndRestore utility class to make that easier. Test Plan: added unit test for SaveAndRestore; existing tests for GetImpl
|
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Jul 28, 2021
util/defer.h
Outdated
| SaveAndRestore& operator=(const SaveAndRestore&) = delete; | ||
|
|
||
| private: | ||
| T* obj_; |
There was a problem hiding this comment.
Nit: how about T* const obj_?
| template <typename T> | ||
| class SaveAndRestore { | ||
| public: | ||
| explicit SaveAndRestore(T* obj) : obj_(obj), saved_(*obj) {} |
There was a problem hiding this comment.
Being paranoid, but I think it is safe to make sure obj is not nullptr.
There was a problem hiding this comment.
By the time we can write assert(obj) we have already used it. I can put it in a comment though
|
@pdillinger has updated the pull request. You must reimport the pull request before landing. |
|
@pdillinger has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@pdillinger merged this pull request in 1d34cd7. |
jaepil
pushed a commit
to deepsearch-hq/rocksdb-backup
that referenced
this pull request
Aug 1, 2021
Summary: Calling the GetImpl function could leave reference to a local callback function in a field of a parameter struct. As this is performance-critical code, I'm not going to attempt to sanitize this code too much, but make the existing hack a bit cleaner by reverting what it overwrites in the input struct. Added SaveAndRestore utility class to make that easier. Pull Request resolved: facebook#8590 Test Plan: added unit test for SaveAndRestore; existing tests for GetImpl Reviewed By: riversand963 Differential Revision: D29947983 Pulled By: pdillinger fbshipit-source-id: 2f608853f970bc06724e834cc84dcc4b8599ddeb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Calling the GetImpl function could leave reference to a local
callback function in a field of a parameter struct. As this is
performance-critical code, I'm not going to attempt to sanitize this
code too much, but make the existing hack a bit cleaner by reverting
what it overwrites in the input struct.
Added SaveAndRestore utility class to make that easier.
Test Plan: added unit test for SaveAndRestore; existing tests for
GetImpl