Attempt to deflake DBTestXactLogIterator.TransactionLogIteratorCorruptedLog #8627
Conversation
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
ltamasi
force-pushed
the
xact_log_iter_test
branch
from
0c9fbce
to
104030b
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…tedLog Summary: The `truncate` syscall used by this test case sometimes fails on our CI. The patch changes the test to use `test::TruncateFile` in an attempt to deflake it. Test Plan: `make check`
… truncating; some minor cleanup
ltamasi
force-pushed
the
xact_log_iter_test
branch
from
d739470
to
a59c738
Compare
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
I believe I've managed to trace the flakiness back to #8591. Based on our discussion with @siying on that PR, I've updated the code to disable file deletions before the @akankshamahajan15 @riversand963 Since there have been some changes since you've approved, could you take another look at the patch? |
Is not Line 133 in e8f218c |
Yes but then it re-enables it, which results in an immediate purge, potentially invalidating the result of the call before the caller gets to use it. Disabling/enabling also at the call site prevents this from happening, since |
Summary:
The patch attempts to deflake
DBTestXactLogIterator.TransactionLogIteratorCorruptedLogby disabling file deletions while retrieving the list of WAL files and truncating the first WAL file.
This is to prevent the
PurgeObsoleteFilescall triggered byGetSortedWalFilesfrominvalidating the result of
GetSortedWalFiles. The patch also cleans up the test case a bitand changes it to using
test::TruncateFileinstead of calling thetruncatesyscall directly.Test Plan:
make check