Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asan_symbolize.py for internal asan build #8737

Closed
wants to merge 2 commits into from
Closed

Remove asan_symbolize.py for internal asan build #8737

wants to merge 2 commits into from

Conversation

jay-zhuang
Copy link
Contributor

@jay-zhuang jay-zhuang commented Sep 1, 2021 •
edited
Loading

Summary: asan_symbolize.py is not compatible with python3. Also make it
consistent with public CI, which doesn't use asan_symbolize.py
And update coverage_test.sh to use python3.

Test Plan: CI

@jay-zhuang
Remove asan_symbolize.py for internal asan build
bee55ba 
Summary: asan_symbolize.py is not compatible with python3. Also make it
consistent with public CI, which doesn't use asan_symbolize.py

Test Plan: CI
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

anand1976
anand1976 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@anand1976 anand1976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anand1976
Copy link
Contributor

@jay-zhuang What does asan_symbolize.py do? Do we lose any functionality by not including it?

@jay-zhuang
Copy link
Contributor Author

jay-zhuang commented Sep 7, 2021 •
edited
Loading

@jay-zhuang What does asan_symbolize.py do? Do we lose any functionality by not including it?

I think the script suppose to print better stack trace when the error happens:
https://helpmanual.io/help/asan_symbolize/
Not sure if it's working properly with our script. I think we can add it back if we find it's necessary (with fixes).

@facebook-github-bot
Copy link
Contributor

@jay-zhuang merged this pull request in 6cca9fa.

yoori pushed a commit to yoori/rocksdb that referenced this pull request Nov 26, 2023
@jay-zhuang
Remove asan_symbolize.py for internal asan build (#8737)
c95a077 
Summary:
asan_symbolize.py is not compatible with python3. Also make it
consistent with public CI, which doesn't use asan_symbolize.py
And update coverage_test.sh to use python3.

Pull Request resolved: facebook/rocksdb#8737

Test Plan: CI

Reviewed By: pdillinger

Differential Revision: D30702430

Pulled By: jay-zhuang

fbshipit-source-id: ef09947b1232294d31b09a855c2f0ce149097dd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdillinger pdillinger pdillinger approved these changes

@anand1976 anand1976 anand1976 approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jay-zhuang @facebook-github-bot @anand1976 @pdillinger