Use GetBlobFileSize instead of GetTotalBlobBytes in DB properties #8902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Sep 12, 2021
We've just added these properties (they weren't part of any previous release), so to me it doesn't seem necessary in this specific case. |
yoori
pushed a commit
to yoori/rocksdb
that referenced
this pull request
Nov 26, 2023
…902) Summary: The patch adjusts the definition of BlobDB's DB properties a bit by switching to `GetBlobFileSize` from `GetTotalBlobBytes`. The difference is that the value returned by `GetBlobFileSize` includes the blob file header and footer as well, and thus matches the on-disk size of blob files. In addition, the patch removes the `Version` number from the `blob_stats` property, and updates/extends the unit tests a little. Pull Request resolved: facebook/rocksdb#8902 Test Plan: `make check` Reviewed By: riversand963 Differential Revision: D30859542 Pulled By: ltamasi fbshipit-source-id: e3426d2d567bd1bd8c8636abdafaafa0743c854c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The patch adjusts the definition of BlobDB's DB properties a bit by
switching to
GetBlobFileSizefromGetTotalBlobBytes. Thedifference is that the value returned by
GetBlobFileSizeincludesthe blob file header and footer as well, and thus matches the on-disk
size of blob files. In addition, the patch removes the
Versionnumberfrom the
blob_statsproperty, and updates/extends the unit tests a little.Test Plan:
make check