InternalStats::DumpCFMapStat: fix sum.w_amp #9065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@riversand963 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Oct 26, 2021
|
@riversand963 merged this pull request in 01bd86a. |
|
Maybe use max double or -1 to indicate this special case if the large number bothers you. I think zero is confusing because it also (and more naturally) means writing nothing. |
We export this value to prometheus + grafana, any non-zero values than makes abnormal graph in grafana. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sum
w_ampwill be a very large number(bytes_written + bytes_written_blob)when there is no any flush and ingest.This PR set sum
w_ampto zero if there is no any flush and ingest, this is conform to per-levelw_ampcomputation.