Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gflags assertion fail #9081

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rockeet
Copy link
Contributor

@rockeet rockeet commented Oct 27, 2021

when using gflags-2.1.2, assertion fails:

db_bench: /builddir/build/BUILD/gflags-2.1.2/src/gflags.cc:250: google::{anonymous}::FlagValue::FlagValue(void*, const char*, bool): Assertion `type_ <= FV_MAX_INDEX' failed.

this commit fix this issue, using uint64 as a fake for uint32 makes no harm for this case

when using gflags-2.1.2, assertion fails:

db_bench: /builddir/build/BUILD/gflags-2.1.2/src/gflags.cc:250: google::{anonymous}::FlagValue::FlagValue(void*, const char*, bool): Assertion `type_ <= FV_MAX_INDEX' failed.

this commit fix this issue, using uint64 as a fake for uint32 makes no harm for this case
Copy link
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see CircleCI doesn't agree with "no harm"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants