Refactor and unify blob file saving and the logic that finds the oldest live blob file #9122
Conversation
…linked SSTs logic
… of MutableBlobFileMetaData
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
db/version_builder.cc
Outdated
|
|
||
| // Add the blob file specified by meta to *vstorage if it is determined to | ||
| // contain valid data (blobs). | ||
| template <typename T> |
There was a problem hiding this comment.
Nit: maybe use a more informative type name than T?
There was a problem hiding this comment.
Sure. Will follow the rebranding process and change it to Meta :)
… template parameters
|
@ltamasi has updated the pull request. You must reimport the pull request before landing. |
|
@ltamasi has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary:
The patch refactors and unifies the logic in
VersionBuilder::SaveBlobFilesToand
VersionBuilder::GetMinOldestBlobFileNumberby introducing a generichelper that can "merge" the list of
BlobFileMetaDatain the base version withthe list of
MutableBlobFileMetaDatarepresenting the updated state afterapplying a sequence of
VersionEdits. This serves as groundwork for subsequentchanges that will enable us to determine whether a blob file is live after applying
a sequence of edits without calling
VersionBuilder::SaveTo.Test Plan:
make check