Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow in TraceOptions #9157

Closed
wants to merge 1 commit into from
Closed

Fix integer overflow in TraceOptions #9157

wants to merge 1 commit into from

Conversation

dfa1
Copy link
Contributor

@dfa1 dfa1 commented Nov 11, 2021

Hello from a happy user of rocksdb java :-)

Default constructor of TraceOptions is supposed to initialize size to 64GB but the expression contains an integer overflow.

Simple test case with JShell:

jshell> 64 * 1024 * 1024 * 1024
$1 ==> 0

jshell> 64L * 1024 * 1024 * 1024
$2 ==> 68719476736

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

pdillinger
pdillinger approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@pdillinger pdillinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@dfa1 has updated the pull request. You must reimport the pull request before landing.

zhichao-cao
zhichao-cao approved these changes Nov 13, 2021
View reviewed changes
Copy link
Contributor

@zhichao-cao zhichao-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@mrambacher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mrambacher merged this pull request in c9539ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdillinger pdillinger pdillinger approved these changes

@zhichao-cao zhichao-cao zhichao-cao approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfa1 @facebook-github-bot @pdillinger @zhichao-cao