Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the QPS verification in test temporally #9190

Closed
wants to merge 1 commit into from
Closed

Disable the QPS verification in test temporally #9190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 22 additions & 0 deletions tools/trace_analyzer_test.cc
View file
Open in desktop
Expand Up @@ -40,6 +40,10 @@ static const int kMaxArgCount = 100;
static const size_t kArgBufferSize = 100000;
} // namespace

// Note that, the QPS part verification of the analyzing result is not robost
// enough and causes the failure in some rare cases. Disable them temporally and
// wait for future refactor.

// The helper functions for the test
class TraceAnalyzerTest : public testing::Test {
public:
Expand Down Expand Up @@ -258,6 +262,7 @@ TEST_F(TraceAnalyzerTest, Get) {
file_path = output_path + "/test-get-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"1 0 0 0 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -273,6 +278,7 @@ TEST_F(TraceAnalyzerTest, Get) {
"The prefix: 0x61 Access count: 1"};
file_path = output_path + "/test-get-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

// Test analyzing of Put
Expand Down Expand Up @@ -333,6 +339,7 @@ TEST_F(TraceAnalyzerTest, Put) {
file_path = output_path + "/test-qps_stats.txt";
CheckFileContent(all_qps, file_path, true);

/*
// Check the qps of Put
std::vector<std::string> get_qps = {"1"};
file_path = output_path + "/test-put-0-qps_stats.txt";
Expand All @@ -349,6 +356,7 @@ TEST_F(TraceAnalyzerTest, Put) {
"Number_of_value_size_between 0 and 16 is: 1"};
file_path = output_path + "/test-put-0-accessed_value_size_distribution.txt";
CheckFileContent(value_dist, file_path, true);
*/
}

// Test analyzing of delete
Expand Down Expand Up @@ -405,6 +413,7 @@ TEST_F(TraceAnalyzerTest, Delete) {
file_path = output_path + "/test-delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 1 0 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -420,6 +429,7 @@ TEST_F(TraceAnalyzerTest, Delete) {
"The prefix: 0x63 Access count: 1"};
file_path = output_path + "/test-delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

// Test analyzing of Merge
Expand Down Expand Up @@ -475,6 +485,7 @@ TEST_F(TraceAnalyzerTest, Merge) {
file_path = output_path + "/test-merge-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 0 1 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -490,6 +501,7 @@ TEST_F(TraceAnalyzerTest, Merge) {
"The prefix: 0x62 Access count: 1"};
file_path = output_path + "/test-merge-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/

// Check the value size distribution
std::vector<std::string> value_dist = {
Expand Down Expand Up @@ -553,6 +565,7 @@ TEST_F(TraceAnalyzerTest, SingleDelete) {
file_path = output_path + "/test-single_delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 1 0 0 0 0 0 1"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -569,6 +582,7 @@ TEST_F(TraceAnalyzerTest, SingleDelete) {
file_path =
output_path + "/test-single_delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

// Test analyzing of delete
Expand Down Expand Up @@ -626,6 +640,7 @@ TEST_F(TraceAnalyzerTest, DeleteRange) {
file_path = output_path + "/test-range_delete-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 2 0 0 0 0 2"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -643,6 +658,7 @@ TEST_F(TraceAnalyzerTest, DeleteRange) {
file_path =
output_path + "/test-range_delete-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

// Test analyzing of Iterator
Expand Down Expand Up @@ -700,6 +716,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path = output_path + "/test-iterator_Seek-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps
std::vector<std::string> all_qps = {"0 0 0 0 0 0 1 1 0 2"};
file_path = output_path + "/test-qps_stats.txt";
Expand All @@ -716,6 +733,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path =
output_path + "/test-iterator_Seek-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/

// Check the output of SeekForPrev
// check the key_stats file
Expand Down Expand Up @@ -753,6 +771,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
output_path + "/test-iterator_SeekForPrev-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the qps of Iterator_SeekForPrev
get_qps = {"1"};
file_path = output_path + "/test-iterator_SeekForPrev-0-qps_stats.txt";
Expand All @@ -763,6 +782,7 @@ TEST_F(TraceAnalyzerTest, Iterator) {
file_path = output_path +
"/test-iterator_SeekForPrev-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

// Test analyzing of multiget
Expand Down Expand Up @@ -827,6 +847,7 @@ TEST_F(TraceAnalyzerTest, MultiGet) {
file_path = output_path + "/test-multiget-0-whole_key_prefix_cut.txt";
CheckFileContent(k_whole_prefix, file_path, true);

/*
// Check the overall qps. We have 3 MultiGet queries and it requested 9 keys
// in total
std::vector<std::string> all_qps = {"0 0 0 0 2 0 0 0 9 11"};
Expand All @@ -846,6 +867,7 @@ TEST_F(TraceAnalyzerTest, MultiGet) {
file_path =
output_path + "/test-multiget-0-accessed_top_k_qps_prefix_cut.txt";
CheckFileContent(top_qps, file_path, true);
*/
}

} // namespace ROCKSDB_NAMESPACE
Expand Down