Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jni: expose memtable_whole_key_filtering option #9394

Closed
wants to merge 5 commits into from
Closed

jni: expose memtable_whole_key_filtering option #9394

wants to merge 5 commits into from

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jan 18, 2022

@javeme javeme changed the title jni: expose memtable_prefix_bloom_size_ratio option jni: expose memtable_whole_key_filtering option Jan 18, 2022
@javeme javeme force-pushed the add-memtable_whole_key_filtering branch from 37d8c07 to 7cfa31a Compare January 18, 2022 08:35
@javeme javeme force-pushed the add-memtable_whole_key_filtering branch from 7cfa31a to fb8d99d Compare January 18, 2022 08:59
alanpaxton
alanpaxton reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@alanpaxton alanpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you change the documentation comment to say "Return boolean indicating whether whole key bloom filter is enabled in memtable". There's not really a mode as such, and it's best when adding to the JNI to directly echo the C++ interface documentation, for clarity.

alanpaxton
alanpaxton reviewed Jan 18, 2022
View reviewed changes
java/src/main/java/org/rocksdb/AdvancedMutableColumnFamilyOptionsInterface.java Outdated
*
* Default: false (disable)
*
* @param memtableWholeKeyFiltering the memtable whole key filtering mode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to put "true iff whole key bloom filter is enabled in memtable" - it's not really a mode.

alanpaxton
alanpaxton reviewed Jan 18, 2022
View reviewed changes
java/src/main/java/org/rocksdb/AdvancedMutableColumnFamilyOptionsInterface.java Outdated
T setMemtableWholeKeyFiltering(boolean memtableWholeKeyFiltering);

/**
* Returns whether a memtable whole key filtering mode will be used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing about comments "Returns whether whole key bloom filter is enabled in memtable"

alanpaxton
alanpaxton reviewed Jan 18, 2022
View reviewed changes
Copy link
Contributor

@alanpaxton alanpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little change. Just a couple of changes I've suggested to the text of method documentation, to keep them as consistent as possible with the C++ documentation.

@javeme
Copy link
Contributor Author

javeme commented Jan 18, 2022

@alanpaxton Thanks for your review. The documentation issue has been resolved now.

ajkr
ajkr approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpaxton alanpaxton alanpaxton left review comments

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@javeme @facebook-github-bot @alanpaxton @ajkr