Remove deprecated option DBOptions::skip_log_error_on_recovery #9434
Conversation
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Thanks @akankshamahajan15 .
Can you update PR description by removing unnecessary sections and update HISTORY.md?
akankshamahajan15
force-pushed
the
skip_log
branch
from
96c77b6
to
4dd5758
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
akankshamahajan15
force-pushed
the
skip_log
branch
from
4dd5758
to
4667be8
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
akankshamahajan15
force-pushed
the
skip_log
branch
from
4667be8
to
776af29
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
akankshamahajan15
force-pushed
the
skip_log
branch
from
776af29
to
415b5cf
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
akankshamahajan15
force-pushed
the
skip_log
branch
from
415b5cf
to
2752205
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
Backward compatible test run for this PR https://app.circleci.com/pipelines/github/facebook/rocksdb/11132/workflows/90b9eecf-dfb3-4949-91e4-de3da7047100/jobs/281000 |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB DBOptions::skip_log_error_on_recovery is marked as "NOT SUPPORTED" for a long time, and setting this option does not have any effect on the behavior of RocksDB library. Therefore, we are removing it in the upcoming 7.0 release. Test Plan: CircleCI
akankshamahajan15
force-pushed
the
skip_log
branch
from
2752205
to
f424483
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB DBOptions::skip_log_error_on_recovery is marked as
"NOT SUPPORTED" for a long time, and setting this option does not have
any effect on the behavior of RocksDB library. Therefore, we are removing it
in the upcoming 7.0 release.
Test Plan: CircleCI