-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated option new_table_reader_for_compaction_inputs #9443
Remove deprecated option new_table_reader_for_compaction_inputs #9443
Conversation
067d8b0
to
6b26536
Compare
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6b26536
to
51ccd67
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
51ccd67
to
4dc1891
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
4dc1891
to
3370144
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
Backward Compatibility test run with this PR: https://app.circleci.com/pipelines/github/facebook/rocksdb/11137/workflows/4abaeccd-b424-449e-ab79-fbee90a534fd/jobs/281207 |
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3370144
to
dc87785
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB option new_table_reader_for_compaction_inputs has not effect on Compaction or on the behavior of RocksDB library. Therefore, we are removing it in the upcoming 7.0 release. Test Plan: CircleCI
dc87785
to
25ed551
Compare
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB option new_table_reader_for_compaction_inputs has
not effect on Compaction or on the behavior of RocksDB library.
Therefore, we are removing it in the upcoming 7.0 release.
Test Plan: CircleCI