Remove Deprecated overloads of DB::GetApproximateSizes #9458
Conversation
There was a problem hiding this comment.
LGTM. Just one concern which does not need to be addressed in this PR.
If we remove these two overloads, a user code calling the removed GetApproximateSizes(..., bool include_memtable) may not be caught by compiler. Instead, the include_memtable:bool may be silently cast to include_flag:uint8_t, leading to incorrect results. I think we should make SizeApproximationFlags an enum class.
akankshamahajan15
force-pushed
the
api_removal
branch
from
ef992ae
to
2c3e71f
Compare
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB few overloads of DB::GetApproximateSizes are marked as DEPRECATED_FUNC, and we are removing it in the upcoming 7.0 release. Test Plan: CircleCI
akankshamahajan15
force-pushed
the
api_removal
branch
from
2c3e71f
to
6cd9dc3
Compare
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@akankshamahajan15 has updated the pull request. You must reimport the pull request before landing. |
|
@akankshamahajan15 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: In RocksDB few overloads of DB::GetApproximateSizes are marked as
DEPRECATED_FUNC, and we are removing it in the upcoming 7.0 release.
Test Plan: CircleCI